Correct name of middleNames Match Score attribute in kyc-match yaml file #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct name of middleNames Match Score attribute
GillesInnov35
requested review from
ToshiWakayama-KDDI and
fernandopradocabrillo
as code owners
|
hi all, this update will break backward compatibility. So could be implemented only in a major version. WDYT |
For KPN no problem, we have not gone live yet with customers |
|
Thanks @GillesInnov35 for the PR. We are actually integrating clients with current version, so let me check the impact with my product team. |
|
thanks @fernandopradocabrillo, yes there's an impact for current implementation using this attribute. It is not the case at Orange France but it could for others countries. So let's see impact to decide then if we delay this evolution to a major version I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct name of middleNames Match Score attribute
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Correct name of middleNames Match Score response attribute.
Replace middleNamesScore by middleNamesMatchScore
Which issue(s) this PR fixes:
Fixes ##161
Special notes for reviewers:
Changelog input